From 5b0d6fdf7d0b4c561532f11438fb401270769d07 Mon Sep 17 00:00:00 2001
From: Jiahao Li <42709836+TheJiahao@users.noreply.github.com>
Date: Sun, 3 Mar 2024 00:48:34 +0200
Subject: [PATCH] fix(sidebar): improve accessibility of sidebar bottom menu
 (#925)

* fix(menu): <ol> containing other than <li>, <script> or <template> elements

* fix(menu): add title to language select menu
---
 layouts/partials/sidebar/left.html | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/layouts/partials/sidebar/left.html b/layouts/partials/sidebar/left.html
index 2f11490..3aed883 100644
--- a/layouts/partials/sidebar/left.html
+++ b/layouts/partials/sidebar/left.html
@@ -74,14 +74,15 @@
             </a>
         </li>
         {{ end }}
-
-        <div class="menu-bottom-section">
+    </ol>
+    <div class="menu-bottom-section">
+        <ol class="menu">
             {{- $currentLanguageCode := .Language.Lang -}}
             {{ if ( compare.Gt .Site.Home.AllTranslations.Len 1 ) }}
                 {{ with .Site.Home.AllTranslations }}
                     <li id="i18n-switch">  
                         {{ partial "helper/icon" "language" }}
-                        <select name="language" onchange="window.location.href = this.selectedOptions[0].value">
+                        <select name="language" title="language" onchange="window.location.href = this.selectedOptions[0].value">
                             {{ range . }}
                                 <option value="{{ .Permalink }}" {{ if eq .Language.Lang $currentLanguageCode }}selected{{ end }}>{{ .Language.LanguageName }}</option>
                             {{ end }}
@@ -97,6 +98,6 @@
                     <span>{{ T "darkMode" }}</span>
                 </li>
             {{ end }}
-        </div>
-    </ol>
+        </ol>
+    </div>
 </aside>