From 25a72940b8184b41de36fec9a3fcdd6387e006b0 Mon Sep 17 00:00:00 2001
From: Jimmy Cai <jimmehcai@gmail.com>
Date: Sun, 20 Dec 2020 11:05:34 +0100
Subject: [PATCH] refactor(opengraph): add default value for twitter:card (#72)

---
 exampleSite/config.yaml                       |  3 ++
 .../head/opengraph/provider/base.html         | 38 +++++++++----------
 .../head/opengraph/provider/twitter.html      |  4 +-
 3 files changed, 24 insertions(+), 21 deletions(-)

diff --git a/exampleSite/config.yaml b/exampleSite/config.yaml
index 7367a49..997f8fa 100644
--- a/exampleSite/config.yaml
+++ b/exampleSite/config.yaml
@@ -62,7 +62,10 @@ params:
 
     opengraph:
         twitter:
+            # Your Twitter username
             site:
+
+            # Available values: summary, summary_large_image
             card: summary_large_image
 
     defaultImage:
diff --git a/layouts/partials/head/opengraph/provider/base.html b/layouts/partials/head/opengraph/provider/base.html
index 8e90a45..3e51d37 100644
--- a/layouts/partials/head/opengraph/provider/base.html
+++ b/layouts/partials/head/opengraph/provider/base.html
@@ -6,35 +6,35 @@
 <meta property='og:url' content='{{ .Permalink }}'>
 <meta property='og:site_name' content='{{ .Site.Title }}'>
 <meta property='og:type' content='
-	{{- if .IsPage -}}
-		article
-  	{{- else -}}
-		website
-  	{{- end -}}
+    {{- if .IsPage -}}
+        article
+    {{- else -}}
+        website
+    {{- end -}}
 '>
 
 {{- with .Params.locale -}}
-  	<meta property='og:locale' content='{{ . }}'>
+    <meta property='og:locale' content='{{ . }}'>
 {{- end -}}
 
 {{- if .IsPage -}}
-  	<meta property='article:section' content='{{ .Section | title }}' />
-	{{- range .Params.tags -}}
-		<meta property='article:tag' content='{{ . }}' />
-	{{- end -}}
+    <meta property='article:section' content='{{ .Section | title }}' />
+    {{- range .Params.tags -}}
+        <meta property='article:tag' content='{{ . }}' />
+    {{- end -}}
 {{- end -}}
 
 {{- if .IsPage -}}
-	{{- if not .Date.IsZero -}}
-		<meta property='article:published_time' content='{{ .Date.Format "2006-01-02T15:04:05-07:00" | safeHTML }}'/>
-	{{- end -}}
-	{{- if not .Lastmod.IsZero -}}
-		<meta property='article:modified_time' content='{{ .Lastmod.Format "2006-01-02T15:04:05-07:00" | safeHTML }}'/>
-	{{- end -}}
+    {{- if not .Date.IsZero -}}
+        <meta property='article:published_time' content='{{ .Date.Format "2006-01-02T15:04:05-07:00" | safeHTML }}'/>
+    {{- end -}}
+    {{- if not .Lastmod.IsZero -}}
+        <meta property='article:modified_time' content='{{ .Lastmod.Format "2006-01-02T15:04:05-07:00" | safeHTML }}'/>
+    {{- end -}}
 {{- else -}}
-	{{- if not .Site.LastChange.IsZero -}}
-		<meta property='og:updated_time' content='{{ .Site.LastChange.Format " 2006-01-02T15:04:05-07:00 " | safeHTML }}'/>
-	{{- end -}}
+    {{- if not .Site.LastChange.IsZero -}}
+        <meta property='og:updated_time' content='{{ .Site.LastChange.Format " 2006-01-02T15:04:05-07:00 " | safeHTML }}'/>
+    {{- end -}}
 {{- end -}}
 
 {{ $image := partialCached "helper/image" (dict "Context" . "Type" "opengraph") .RelPermalink "opengraph" }}
diff --git a/layouts/partials/head/opengraph/provider/twitter.html b/layouts/partials/head/opengraph/provider/twitter.html
index ecb6680..e74441d 100644
--- a/layouts/partials/head/opengraph/provider/twitter.html
+++ b/layouts/partials/head/opengraph/provider/twitter.html
@@ -10,6 +10,6 @@
 
 {{- $image := partialCached "helper/image" (dict "Context" . "Type" "opengraph") .RelPermalink "opengraph" -}}
 {{- if $image.exists -}}
-	<meta name="twitter:card" content="{{ .Site.Params.opengraph.twitter.card }}">
-	<meta name="twitter:image" content='{{ absURL $image.permalink }}' />
+    <meta name="twitter:card" content="{{ default `summary_large_image` .Site.Params.opengraph.twitter.card }}">
+    <meta name="twitter:image" content='{{ absURL $image.permalink }}' />
 {{- end -}}
\ No newline at end of file